Configuration used: defaults

Review profile: CHILL

Plan: Pro

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

livekit-plugins/livekit-plugins-bithuman/livekit/plugins/bithuman/avatar.py (5)

320-320: Line exceeds 100 characters.

Per coding guidelines, the maximum line length is 100 characters. This line should be wrapped.

♻️ Proposed fix

-            await self._send_formdata_request(livekit_url, livekit_token, room_name, async_mode=async_mode)
+            await self._send_formdata_request(
+                livekit_url, livekit_token, room_name, async_mode=async_mode
+            )

---

378-381: Unreachable code branch for bytes type.

The __init__ method (lines 156-165) only sets _avatar_image to Image.Image or str, never bytes. This branch is dead code.

Consider removing this branch or updating __init__ to support bytes input if that's intended functionality.

♻️ Proposed fix (remove dead code)

         if isinstance(self._avatar_image, Image.Image):
             img_byte_arr = io.BytesIO()
             self._avatar_image.save(img_byte_arr, format="JPEG", quality=95)
             img_byte_arr.seek(0)
             import base64

             json_data["image"] = base64.b64encode(img_byte_arr.getvalue()).decode("utf-8")
-        elif isinstance(self._avatar_image, bytes):
-            import base64
-
-            json_data["image"] = base64.b64encode(self._avatar_image).decode("utf-8")
         elif isinstance(self._avatar_image, str):
             json_data["image"] = self._avatar_image

---

468-476: Unreachable code branch for bytes type (same as _send_json_request).

The __init__ method never sets _avatar_image to bytes, making this branch dead code.

♻️ Proposed fix (remove dead code)

         if isinstance(self._avatar_image, Image.Image):
             # Convert PIL Image to bytes and upload as file
             img_byte_arr = io.BytesIO()
             self._avatar_image.save(img_byte_arr, format="JPEG", quality=95)
             img_byte_arr.seek(0)
             form_data.add_field(
                 "avatar_image",
                 img_byte_arr,
                 filename="avatar.jpg",
                 content_type="image/jpeg",
             )
-        elif isinstance(self._avatar_image, bytes):
-            # Upload raw bytes as file
-            img_byte_arr = io.BytesIO(self._avatar_image)
-            form_data.add_field(
-                "avatar_image",
-                img_byte_arr,
-                filename="avatar.jpg",
-                content_type="image/jpeg",
-            )
         elif isinstance(self._avatar_image, str):

---

494-496: Silent fallback to URL on base64 decode failure may mask errors.

If the string is intended to be base64 but is malformed, silently treating it as a URL will cause a confusing server-side failure. Consider logging a warning or validating the string format before attempting decode.

♻️ Proposed fix

                 except Exception:
-                    # If decode fails, treat as URL
-                    form_data.add_field("avatar_image_url", self._avatar_image)
+                    # If decode fails, log warning and treat as URL
+                    logger.warning(
+                        "Failed to decode avatar_image as base64, treating as URL",
+                        extra={"avatar_image": self._avatar_image[:50] + "..." if len(self._avatar_image) > 50 else self._avatar_image},
+                    )
+                    form_data.add_field("avatar_image_url", self._avatar_image)

---

543-547: Passing both json and data to aiohttp.post() is ambiguous.

The docstring states json_data and form_data are mutually exclusive, but both are always passed to post(). While aiohttp prioritizes json when both are provided, this implicit behavior is fragile. Consider adding a runtime check or only passing the non-None parameter.

♻️ Proposed fix

+        if json_data is not None and form_data is not None:
+            raise ValueError("json_data and form_data are mutually exclusive")
+
         for i in range(self._conn_options.max_retry):
             try:
-                async with self._ensure_http_session().post(
-                    self._api_url,
-                    headers=headers,
-                    json=json_data,
-                    data=form_data,
-                    timeout=aiohttp.ClientTimeout(sock_connect=self._conn_options.timeout),
-                ) as response:
+                kwargs: dict[str, Any] = {
+                    "headers": headers,
+                    "timeout": aiohttp.ClientTimeout(sock_connect=self._conn_options.timeout),
+                }
+                if json_data is not None:
+                    kwargs["json"] = json_data
+                elif form_data is not None:
+                    kwargs["data"] = form_data
+
+                async with self._ensure_http_session().post(
+                    self._api_url,
+                    **kwargs,
+                ) as response:

Note: You'll need to add from typing import Any if not already imported.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: livekit/agents PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-16T07:44:56.353Z
Learning: Applies to **/*.py : Run ruff linter and auto-fix issues

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

livekit-plugins/livekit-plugins-bithuman/livekit/plugins/bithuman/avatar.py (1)

521-565: Add a guard to enforce payload mutual exclusivity.
Helps catch accidental misuse early.

♻️ Proposed refactor

     async def _send_request_with_retry(
         self,
         headers: dict[str, str],
         json_data: dict | None = None,
         form_data: aiohttp.FormData | None = None,
     ) -> None:
@@
-        for i in range(self._conn_options.max_retry):
+        if (json_data is None) == (form_data is None):
+            raise ValueError("Exactly one of json_data or form_data must be provided")
+
+        for i in range(self._conn_options.max_retry):

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: livekit/agents PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-16T07:44:56.353Z
Learning: Applies to **/*.py : Run ruff linter and auto-fix issues

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

livekit-plugins/livekit-plugins-bithuman/livekit/plugins/bithuman/avatar.py (2)

352-365: Custom endpoints are still blocked by cloud-mode api_secret validation.

This branch supports api_token auth for custom endpoints, but __init__ still raises when api_secret is missing, which prevents token-only configurations from reaching this path. Consider gating the api_secret requirement to default endpoints (or requiring either token or secret for custom endpoints).

🔧 Suggested fix (in __init__ cloud-mode validation)

         elif self._mode == "cloud":
             if not utils.is_given(avatar_image) and not utils.is_given(avatar_id):
                 raise BitHumanException("`avatar_image` or `avatar_id` must be set for cloud mode")
-            if self._api_secret is None:
-                raise BitHumanException("BITHUMAN_API_SECRET are required for cloud mode")
+            if self._is_default_api_url():
+                if self._api_secret is None:
+                    raise BitHumanException("BITHUMAN_API_SECRET is required for default API")
+            elif self._api_secret is None and self._api_token is None:
+                raise BitHumanException(
+                    "BITHUMAN_API_TOKEN or BITHUMAN_API_SECRET is required for custom endpoints"
+                )
             if self._api_url is None:
                 raise BitHumanException("BITHUMAN_API_URL are required for cloud mode")

---

428-433: Narrow api_secret to str before building headers.

The assert only excludes None; strict typing can still see a non-str sentinel and produce dict[str, str | NotGiven]. This can break mypy strict and send invalid headers at runtime.

✅ Proposed fix

-        assert self._api_secret is not None, "api_secret is required for default API"
-
-        headers = {
-            "Content-Type": "application/json",
-            "api-secret": self._api_secret,
-        }
+        api_secret = self._api_secret
+        if not isinstance(api_secret, str):
+            raise BitHumanException("BITHUMAN_API_SECRET is required for default API")
+        headers = {
+            "Content-Type": "application/json",
+            "api-secret": api_secret,
+        }

To verify the sentinel’s behavior, inspect NotGiven/NOT_GIVEN definitions and truthiness:

#!/bin/bash
rg -n -C3 "class NotGiven|NOT_GIVEN"
rg -n -C3 "def is_given"

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: livekit/agents PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-16T07:44:56.353Z
Learning: Applies to **/*.py : Run ruff linter and auto-fix issues

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

livekit-plugins/livekit-plugins-bithuman/livekit/plugins/bithuman/avatar.py (1)

509-517: Same unreachable code - bytes type check.

This branch has the same issue as _send_json_request: _avatar_image cannot be bytes per its type annotation.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: livekit/agents PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-16T07:44:56.353Z
Learning: Applies to **/*.py : Run ruff linter and auto-fix issues

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

livekit-plugins/livekit-plugins-bithuman/livekit/plugins/bithuman/avatar.py (1)

63-63: Consider moving re import to module level.

The re module is imported inside the function on each call. For consistency with other imports (like base64 at line 4), consider moving it to the module-level imports.

♻️ Suggested change

At the top of the file (around line 10):

import re

Then remove line 63 from the function.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: livekit/agents PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-16T07:44:56.353Z
Learning: Applies to **/*.py : Run ruff linter and auto-fix issues

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

livekit-plugins/livekit-plugins-bithuman/livekit/plugins/bithuman/avatar.py (1)

556-561: Consider more precise type annotation for json_data.

The dict type is generic. For stricter mypy compliance, consider using dict[str, Any].

♻️ Suggested improvement

     async def _send_request_with_retry(
         self,
         headers: dict[str, str],
-        json_data: dict | None = None,
+        json_data: dict[str, Any] | None = None,
         form_data: aiohttp.FormData | None = None,
     ) -> None:

You'll need to add Any to the imports:

-from typing import TYPE_CHECKING, Literal
+from typing import TYPE_CHECKING, Any, Literal

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: livekit/agents PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-16T07:44:56.353Z
Learning: Applies to **/*.py : Run ruff linter and auto-fix issues

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}